diff options
author | Patrick Spek <p.spek@tyil.nl> | 2020-03-22 13:44:01 +0100 |
---|---|---|
committer | Patrick Spek <p.spek@tyil.nl> | 2020-03-22 13:44:01 +0100 |
commit | 1548063b6ac54affecccc19872b1ffeed64f0887 (patch) | |
tree | 645d7ec3faeff40be96172b134023510334b5b6a /lib/actions/install.bash | |
parent | e335ffb41f7d65f369a8e4170affcd8d68a40be2 (diff) |
Work out (most?) issues reported by shellcheck
Diffstat (limited to 'lib/actions/install.bash')
-rw-r--r-- | lib/actions/install.bash | 19 |
1 files changed, 14 insertions, 5 deletions
diff --git a/lib/actions/install.bash b/lib/actions/install.bash index 30b88dd..b2faefd 100644 --- a/lib/actions/install.bash +++ b/lib/actions/install.bash @@ -14,12 +14,15 @@ RSTAR_DEPS_PERL+=( action() { local OPTIND + local prefix_absolute + local modules while getopts ":b:p:" opt do case "$opt" in b) RSTAR_BACKEND=$OPTARG ;; p) RSTAR_PREFIX=$OPTARG ;; + *) emerg "Invalid option specified: $opt" ;; esac done @@ -27,7 +30,7 @@ action() { # TODO: Check if binaries are available mkdir -p -- "$RSTAR_PREFIX" - local prefix_absolute="$(CDPATH="" cd -- "$RSTAR_PREFIX" && pwd -P)" + prefix_absolute="$(CDPATH="" cd -- "$RSTAR_PREFIX" && pwd -P)" info "Installing Raku in $prefix_absolute" @@ -45,8 +48,11 @@ action() { # Install community modules failed_modules=() + modules="$(tmpfile)" - for module in $(awk '/^[^#]/ {print $1}' "$BASEDIR/etc/modules.txt") + awk '/^[^#]/ {print $1}' "$BASEDIR/etc/modules.txt" > "$modules" + + while read -r module do info "Installing $module" @@ -54,10 +60,10 @@ action() { && continue failed_modules+=("$module") - done + done < "$modules" # Show a list of all modules that failed to install - if [[ $failed_modules ]] + if [[ ${failed_modules[*]} ]] then crit "The following modules failed to install:" @@ -68,6 +74,7 @@ action() { fi # Friendly message + # TODO: Add information on the time it took" info "Rakudo Star has been installed into $prefix_absolute!" info "You may need to add the following paths to your \$PATH:" info " $prefix_absolute/bin" @@ -113,7 +120,9 @@ build_rakudo() { build_prepare() { local source="$1" - local destination="$(tempdir)" + local destination + + destination="$(tmpdir)" notice "Using $destination as working directory" |